Conversation
anzz1
requested review from
Green-Sky,
blackhole89,
ggerganov and
sw
and removed request for
ggerganov
Green-Sky
approved these changes
Mar 23, 2023
Green-Sky
suggested changes
Mar 23, 2023
Contributor
Author
|
Hm it got stuck on "change requested" even when it's resolved? |
Green-Sky
approved these changes
Mar 23, 2023
Collaborator
wdym? |
sw
approved these changes
Mar 23, 2023
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
* command line args bounds checking * unknown and invalid param exit codes 0 -> 1
phuongncn
pushed a commit
to phuongncn/llama.cpp-gx10-dgx-sparks-deepseekv4
that referenced
this pull request
Apr 28, 2026
* command line args bounds checking * unknown and invalid param exit codes 0 -> 1
phuongncn
pushed a commit
to phuongncn/llama.cpp-gx10-dgx-sparks-deepseekv4
that referenced
this pull request
Apr 28, 2026
Co-authored-by: Iwan Kawrakow <iwan.kawrakow@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bound check command line argument parameters so it doesn't crash / do out-of-bounds read when entering empty param.
Outputs a "invalid parameter" error in this case.
before: "./main -r " = crash