Server: fix server hangs on empty prompt#5733
Merged
ngxson merged 1 commit intoggml-org:masterfrom Feb 26, 2024
Merged
Conversation
phymbert
approved these changes
Feb 26, 2024
Collaborator
phymbert
left a comment
There was a problem hiding this comment.
Can we hardcode a default embeddings answer as OpenAI ? Do you think it deserve a small test scenario ?
Contributor
Author
|
I don't think we should hard code the result, as it's vector and not a fixed text value (so we may expect different floating point inaccuracy on different hardwares) But what we can do for the test is:
|
Contributor
|
Can we also fix the issue where incorrect grammar crashes the server? Last I checked there was a boolean check at the top of the server code which validated the input args. I think we could move the grammar validation outside of that and just return None or Error if incorrect grammar is passed. |
Closed
jordankanter
pushed a commit
to jordankanter/llama.cpp
that referenced
this pull request
Mar 13, 2024
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
phuongncn
pushed a commit
to phuongncn/llama.cpp-gx10-dgx-sparks-deepseekv4
that referenced
this pull request
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposal to fix #5724 and #5246
It's buggy when we run a slot with no tokens to evaluate, since some parts of code implicitly expect
n_tokensto be> 0This PR fixes issue when using:
/v1/embeddingswith"input": ""/embeddingwith"content": ""/completionwith"prompt": ""