fix build break by iq1s#6010
Conversation
| return d * sumi; | ||
| int sumi1 = 0, sumi2 = 0, sumi3 = 0, sumi4 = 0; | ||
| const uint8_t h1 = bq1->scales[2*ib32+0]; | ||
| const uint8_t h2 = bq1->scales[2*ib32+1]; |
There was a problem hiding this comment.
| const uint8_t h2 = bq1->scales[2*ib32+1]; | |
| const uint8_t h2 = bq1->qh[2*ib32+1]; |
There was a problem hiding this comment.
I restore the structure with "scales"
There was a problem hiding this comment.
You should not restore scales - the data structure was changed to improve the quality of IQ1_S. The kernels should be adapted to follow the CUDA implementation
Does this even pass the tests when you run test-backend-ops?
There was a problem hiding this comment.
yes, it can pass with CI in my local test.
But, I want to abandon this PR. base is changed more frequently. :<
We need to fix the SYCL backend build as soon.
Follow CUDA code is not important, if SYCL backend work well.
There was a problem hiding this comment.
Ok, if you want, you can close the PR
Make sure to take a look at #6014 when you get to this
|
I'd like to restore SYCL backend build as soon as possible. |
|
abandon due to this issue has been fixed by other PR. |
3 participants
fix the build break issue created by "Add q3_s and q1_s"