Skip to content

[SYCL] Update get version#6025

Merged
abhilash1910 merged 1 commit intoggml-org:masterfrom
AidanBeltonS:update_get_version
Mar 13, 2024
Merged

[SYCL] Update get version#6025
abhilash1910 merged 1 commit intoggml-org:masterfrom
AidanBeltonS:update_get_version

Conversation

@AidanBeltonS
Copy link
Copy Markdown
Contributor

This PR updates the get_version implementation in the DPCT headers to work with AMD GPUs.
As is AMD GPUs crash with error:

terminate called after throwing an instance of 'std::invalid_argument'
  what():  stoi
Aborted

This is a problem in the DPCT headers, I have already raised the issue upstream.
oneapi-src/SYCLomatic#1779

@AidanBeltonS
Copy link
Copy Markdown
Contributor Author

@abhilash1910, @airMeng, @OuadiElfarouki, feedback welcome

Copy link
Copy Markdown

@wenhuiNi wenhuiNi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can create a pr to DPCT/SYCLomatic repo. Upstream this fix pr directly.

@abhilash1910
Copy link
Copy Markdown
Contributor

@AidanBeltonS could you please rebase to latest master?

@abhilash1910 abhilash1910 merged commit b3d9786 into ggml-org:master Mar 13, 2024
@NeoZhangJianyu
Copy link
Copy Markdown
Contributor

@AidanBeltonS
The code indentation is 2, but it's required 4.

@airMeng
Copy link
Copy Markdown
Contributor

airMeng commented Mar 15, 2024

@AidanBeltonS The code indentation is 2, but it's required 4.

shall we apply clang-format for sycl part?

NeoZhangJianyu pushed a commit to NeoZhangJianyu/llama.cpp that referenced this pull request Mar 15, 2024
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
phuongncn pushed a commit to phuongncn/llama.cpp-gx10-dgx-sparks-deepseekv4 that referenced this pull request Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants