Skip to content

server: test: disable debug release type sanitizer, simplify trigger#6047

Merged
ggerganov merged 1 commit intomasterfrom
hp/server/tests/disable-sanitizer-thread-debug
Mar 14, 2024
Merged

server: test: disable debug release type sanitizer, simplify trigger#6047
ggerganov merged 1 commit intomasterfrom
hp/server/tests/disable-sanitizer-thread-debug

Conversation

@phymbert
Copy link
Copy Markdown
Collaborator

@phymbert phymbert commented Mar 13, 2024 •
edited
Loading

Motivation

  • Server tests with cmake release type Debug are extremely slow with Thread sanitizer, blocking the CI on each pull request action.
  • Recently, GitHub free CI runners are extremly slow, server startup time increased.
  • -fsanitize=* are broken:
AddressSanitizer:DEADLYSIGNAL
... or ...
FATAL: ThreadSanitizer: unexpected memory mapping 0x571167ebd000-0x571167ecd000

Changes

  • Disable the -fsanitize=thread with -DCMAKE_BUILD_TYPE=Debug matrix entry for pull request.
  • Simplify matrix and step conditions.
  • Do not fail fast in order to ensure at least Release is still passing.
  • Increase max attempts in health check and server startup.

References

@phymbert phymbert requested review from ggerganov and ngxson and removed request for ggerganov and ngxson March 13, 2024 21:28
@phymbert phymbert marked this pull request as draft March 13, 2024 22:01
@phymbert phymbert force-pushed the hp/server/tests/disable-sanitizer-thread-debug branch from f0b15fd to 80e0be9 Compare March 13, 2024 22:06
@phymbert
server: test: disable debug release type sanitizer thread on PR, simp…
0fa925c 
…lify triggers and matrix

 - increase time out for server
 - do not fail fast
@phymbert phymbert force-pushed the hp/server/tests/disable-sanitizer-thread-debug branch from c934ac5 to 0fa925c Compare March 13, 2024 22:46
@phymbert phymbert requested a review from ngxson March 13, 2024 22:47
@phymbert phymbert marked this pull request as ready for review March 13, 2024 22:47
@ggerganov ggerganov merged commit 43241ad into master Mar 14, 2024
@ggerganov ggerganov deleted the hp/server/tests/disable-sanitizer-thread-debug branch March 14, 2024 11:15
NeoZhangJianyu pushed a commit to NeoZhangJianyu/llama.cpp that referenced this pull request Mar 15, 2024
@phymbert @NeoZhangJianyu
server: disable debug release type sanitizer, simplify trigger (ggml-…
9d16ae7 
…org#6047)

- increase time out for server
 - do not fail fast
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
@phymbert
server: disable debug release type sanitizer, simplify trigger (ggml-…
61059e5 
…org#6047)

- increase time out for server
 - do not fail fast
phuongncn pushed a commit to phuongncn/llama.cpp-gx10-dgx-sparks-deepseekv4 that referenced this pull request Apr 28, 2026
@phymbert
server: disable debug release type sanitizer, simplify trigger (ggml-…
0c0c027 
…org#6047)

- increase time out for server
 - do not fail fast
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggerganov ggerganov ggerganov approved these changes

@ngxson ngxson Awaiting requested review from ngxson

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@phymbert @ggerganov