Skip to content

ggml:fix finding transfer queue family index error#6094

Merged
0cc4m merged 1 commit intoggml-org:masterfrom
GainLee:master
Mar 17, 2024
Merged

ggml:fix finding transfer queue family index error#6094
0cc4m merged 1 commit intoggml-org:masterfrom
GainLee:master

Conversation

@GainLee
Copy link
Copy Markdown
Contributor

@GainLee GainLee commented Mar 16, 2024

The may be a error on the method ggml_vk_find_queue_family_index on some devices.

All commands that are allowed on a queue that supports transfer operations are also allowed on a queue that supports either graphics or compute operations. Thus, if the capabilities of a queue family include VK_QUEUE_GRAPHICS_BIT or VK_QUEUE_COMPUTE_BIT, then reporting the VK_QUEUE_TRANSFER_BIT capability separately for that queue family is optional.

https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VkQueueFlagBits.html

@cebtenzzre cebtenzzre requested a review from 0cc4m March 17, 2024 04:46
Copy link
Copy Markdown
Contributor

@0cc4m 0cc4m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, good idea.

@0cc4m 0cc4m merged commit dc0f612 into ggml-org:master Mar 17, 2024
hodlen pushed a commit to hodlen/llama.cpp that referenced this pull request Apr 3, 2024
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
phuongncn pushed a commit to phuongncn/llama.cpp-gx10-dgx-sparks-deepseekv4 that referenced this pull request Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants