Fixed Windows MSVC Compilation#6096
Closed
deacon8 wants to merge 1 commit intoggml-org:masterfrom
deacon8:master
Closed
Fixed Windows MSVC Compilation#6096deacon8 wants to merge 1 commit intoggml-org:masterfrom deacon8:master
deacon8 wants to merge 1 commit intoggml-org:masterfrom
deacon8:master
Conversation
This was referenced Mar 16, 2024
Member
|
Superseded by #6101 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick and ugly fix.
MSVC only allows for a certain number of nested if's.
Since else-if's count as nested, moving the affected branch up one else-if position is enough for compilation.
Not very sustainable moving forward though, so some refactoring would probably be good.
fixes #6093