Update llava-cli.cpp to support comma-delimited image lists#6307
Closed
cpumaxx wants to merge 10 commits intoggml-org:masterfrom
Closed
Update llava-cli.cpp to support comma-delimited image lists#6307cpumaxx wants to merge 10 commits intoggml-org:masterfrom
cpumaxx wants to merge 10 commits intoggml-org:masterfrom
Conversation
Add in the ability to specify a comma-delimited list of images at the command line for batch-processing of multiple images without needing to reload the model file.
cleanup whitespace
mscheong01
suggested changes
Apr 1, 2024
Collaborator
mscheong01
left a comment
mscheong01
left a comment
There was a problem hiding this comment.
I had to do something similar when implementing the retrieval example: receive multiple files to one parameter. It seems that the most preferred method for this is to get the users to specify the parameter multiple times for multiple files.
Can you fix this modification as likewise?
Details: #6193 (comment)
Add the ability to specify --image multiple times
Update help text
mscheong01
reviewed
Apr 7, 2024
change params image datatype to vector
update image flag processing code to work with vector type
Change functions to use image as a vector datatype
Contributor
Author
|
Is there anything else needed before this PR can be merged? |
ggerganov
approved these changes
Apr 22, 2024
mscheong01
approved these changes
Apr 22, 2024
Collaborator
mscheong01
left a comment
mscheong01
left a comment
There was a problem hiding this comment.
Please fix the merge conflicts too. Thanks for your contribution 👍
also need to update function body and call Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
Updated llava main function to pass image correctly for updated load_image
fix image param and add additional help info text
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the ability to specify a comma-delimited list of images to llava-cli for batch-processing of multiple images without needing to reload the model file.
If this overall approach is acceptable, we can clean up variable names, help text, etc