Skip to content

ci: bench: fix Resource not accessible by integration on PR event#6393

Merged
ggerganov merged 1 commit intoggml-org:masterfrom
phymbert:hp/ci/bench
Mar 30, 2024
Merged

ci: bench: fix Resource not accessible by integration on PR event#6393
ggerganov merged 1 commit intoggml-org:masterfrom
phymbert:hp/ci/bench

Conversation

@phymbert
Copy link
Copy Markdown
Collaborator

Context

Facing Resource not accessible by integration on Benchmark workflow on PR created from forks, example:

This is expected according to the github documentation, the GITHUB_TOKEN has read permission on PR from fork.

Change

Switch trigger event from pull_request to pull_request_target.

Explained on github documentation:

For workflows that are triggered by the pull_request_target event, the GITHUB_TOKEN is granted read/write repository permission

As we need write permission for commit status and and PR comment.

@phymbert phymbert marked this pull request as draft March 30, 2024 07:47
@phymbert phymbert requested a review from ggerganov March 30, 2024 08:30
@phymbert phymbert marked this pull request as ready for review March 30, 2024 08:30
@phymbert
Copy link
Copy Markdown
Collaborator Author

phymbert commented Mar 30, 2024

@ggerganov Georgi, let's try this approach, probably need to change some variables inside the workflow later on. But need to be merged first

@ggerganov ggerganov merged commit 37e7854 into ggml-org:master Mar 30, 2024
@phymbert phymbert deleted the hp/ci/bench branch March 30, 2024 10:45
hodlen pushed a commit to hodlen/llama.cpp that referenced this pull request Apr 3, 2024
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
phuongncn pushed a commit to phuongncn/llama.cpp-gx10-dgx-sparks-deepseekv4 that referenced this pull request Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants