Skip to content

license : add AUTHORS#6405

Merged
ggerganov merged 3 commits intomasterfrom
gg/authors
Apr 9, 2024
Merged

license : add AUTHORS#6405
ggerganov merged 3 commits intomasterfrom
gg/authors

Conversation

@ggerganov
Copy link
Copy Markdown
Member

@ggerganov ggerganov commented Mar 31, 2024

ref: #6394

  • Update copyrights to acknowledge all contributors to the project
  • Generate AUTHORS file based on git history - will be manually updated periodically
  • Same changes will be applied to ggml and whisper.cpp

Copy link
Copy Markdown
Collaborator

@phymbert phymbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that

Comment thread AUTHORS Outdated
qunash <anzoria@gmail.com>
Erik Scholz <Green-Sky@users.noreply.github.com>
Qingyou Meng <meng.qingyou@gmail.com>
slaren <2141330+slaren@users.noreply.github.com>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who is the real @slaren :)

@JohannesGaessler
Copy link
Copy Markdown
Contributor

This would of course be more work but I think in addition to a huge list that includes everyone I think it would make sense to also add a short list for the core contributors that briefly describes what they have worked on. Even as it is I am receiving many unsolicited job offers via email and due to that some of my current llama.cpp contributions are being financially supported by a third party. I was also offered sponsorship in terms of free hardware in the past. But presumably if it were easier for third parties to understand who is contributing what to the project this would also lead to more opportunities and financial resources for project contributors, which would in turn allow them to invest more time into the project.

Comment thread LICENSE Outdated
@JohannesGaessler
Copy link
Copy Markdown
Contributor

I forgot: a short list of the core contributors would also be useful for onboarding. I personally will happily use an hour of my time explaining the project to someone who is interested in working on it but doesn't know where to start. I'm saying as much on my Github page but a more visible location in the actual repository would I think be useful.

@netrunnereve
Copy link
Copy Markdown
Collaborator

netrunnereve commented Mar 31, 2024

Are we planning to have contributors run this script and commit this file along with every PR? Otherwise this will become outdated fast. By the way for other open source projects I often just see in the MIT license something like Copyright (c) 2023-2024 OWNER and all contributors, which would basically acknowledge everyone who worked on the project. If someone wants to get all the names they can pull it from Git, along with the specific changes that person made and so forth.

I forgot: a short list of the core contributors would also be useful for onboarding. I personally will happily use an hour of my time explaining the project to someone who is interested in working on it but doesn't know where to start. I'm saying as much on my Github page but a more visible location in the actual repository would I think be useful.

If you're willing to do that 😃 I think it would be more worthwhile to record a one hour screencast going over the project structure and recommend it to new contributors in the README. Currently a lot of information is hidden away in PR comments and the code itself.

@ggerganov ggerganov marked this pull request as draft March 31, 2024 16:02
@JohannesGaessler
Copy link
Copy Markdown
Contributor

If you're willing to do that 😃 I think it would be more worthwhile to record a one hour screencast going over the project structure and recommend it to new contributors in the README. Currently a lot of information is hidden away in PR comments and the code itself.

Text documentation >> video documentation. Documentation is also helpful but the scaling is very different. Writing documentation is going to be more efficient for onboarding thousands of devs but for onboarding < 10 it will be more efficient for me to just talk to them.

@ggerganov ggerganov marked this pull request as ready for review April 9, 2024 06:22
@ggerganov ggerganov merged commit e11a899 into master Apr 9, 2024
@ggerganov
Copy link
Copy Markdown
Member Author

This would of course be more work but I think in addition to a huge list that includes everyone I think it would make sense to also add a short list for the core contributors that briefly describes what they have worked on.

Sounds good - open to suggestions

Are we planning to have contributors run this script and commit this file along with every PR?

Completely optional - we'll run the script from time to time to have a somewhat up-to-date information in the AUTHORS file. The git history is the reference anyway

Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
* license : add AUTHORS

* authors : update

* scipts : add LICENSE and gen-authors.sh to sync
phuongncn pushed a commit to phuongncn/llama.cpp-gx10-dgx-sparks-deepseekv4 that referenced this pull request Apr 28, 2026
* license : add AUTHORS

* authors : update

* scipts : add LICENSE and gen-authors.sh to sync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants