Skip to content

server: allow setting penalize-nl on server webpage#6431

Merged
phymbert merged 1 commit intoggml-org:masterfrom
sha224:server-penalize-nl
Apr 4, 2024
Merged

server: allow setting penalize-nl on server webpage#6431
phymbert merged 1 commit intoggml-org:masterfrom
sha224:server-penalize-nl

Conversation

@sha224
Copy link
Copy Markdown
Contributor

@sha224 sha224 commented Apr 2, 2024

This change allows users to set penalize-nl on the server webpage which fixes #6430 .

The user can set penalize-nl by using a checkbox shown in the following screenshot.
Screenshot_20240401_231105

@github-actions

This comment was marked as off-topic.

Copy link
Copy Markdown
Collaborator

@phymbert phymbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use spaces instead of tabs. See the linter issues

@sha224 sha224 force-pushed the server-penalize-nl branch 2 times, most recently from 9044c20 to a6c07e3 Compare April 2, 2024 10:07
@sha224
Copy link
Copy Markdown
Contributor Author

sha224 commented Apr 2, 2024

I have addressed the tab issue.

@Jeximo
Copy link
Copy Markdown
Contributor

Jeximo commented Apr 2, 2024

For certain models, the chat causes infinite newlines after a few turns.

I'm a bit confused because all #6127 did was set repeat-pentalty to 1.0(disabled) whereas server docs show penalize-nl defaults to true... Is the readme wrong?

Does setting repeat-penalty to default 1.1 fix #6430?

Either way, I like the addition of a penalize-nl button within server.

Edit: Ah, further checking and the server readme is outdated because #6127 also set penalize-nl to false, and there's no command line to change the value to true.

Comment thread examples/server/public/index.html Outdated
@sha224 sha224 force-pushed the server-penalize-nl branch 2 times, most recently from 8ab82cd to 8cb2a59 Compare April 3, 2024 00:32
@sha224 sha224 force-pushed the server-penalize-nl branch from 8cb2a59 to 6f7ab29 Compare April 3, 2024 01:02
@sha224 sha224 requested a review from phymbert April 3, 2024 01:15
Copy link
Copy Markdown
Contributor

@ngxson ngxson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll wait for @phymbert to review once more and merge it.

@phymbert phymbert merged commit 2e66913 into ggml-org:master Apr 4, 2024
@phymbert
Copy link
Copy Markdown
Collaborator

phymbert commented Apr 4, 2024

@ngxson thanks, please note the new step in Server CI Verify server deps dedicated for this kind of PR.

Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
phuongncn pushed a commit to phuongncn/llama.cpp-gx10-dgx-sparks-deepseekv4 that referenced this pull request Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Server: Infinite newlines during chat on server webpage

4 participants