[SYCL] Fixed minor bug when enabling FP16 for non intel targets#6464
Merged
abhilash1910 merged 5 commits intoggml-org:masterfrom Apr 5, 2024
Merged
[SYCL] Fixed minor bug when enabling FP16 for non intel targets#6464abhilash1910 merged 5 commits intoggml-org:masterfrom
abhilash1910 merged 5 commits intoggml-org:masterfrom
Conversation
Co-authored-by: AidanBeltonS <87009434+AidanBeltonS@users.noreply.github.com>
Contributor
AidanBeltonS
approved these changes
Apr 4, 2024
abhilash1910
approved these changes
Apr 4, 2024
Contributor
abhilash1910
left a comment
There was a problem hiding this comment.
LGTM!
pinging @NeoZhangJianyu @ggerganov for a look when available
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
…-org#6464) * moved INTEL_MKL guard from gemm_impl to gemm (wrapper) * Update ggml-sycl.cpp Co-authored-by: AidanBeltonS <87009434+AidanBeltonS@users.noreply.github.com> --------- Co-authored-by: AidanBeltonS <87009434+AidanBeltonS@users.noreply.github.com>
phuongncn
pushed a commit
to phuongncn/llama.cpp-gx10-dgx-sparks-deepseekv4
that referenced
this pull request
Apr 28, 2026
…-org#6464) * moved INTEL_MKL guard from gemm_impl to gemm (wrapper) * Update ggml-sycl.cpp Co-authored-by: AidanBeltonS <87009434+AidanBeltonS@users.noreply.github.com> --------- Co-authored-by: AidanBeltonS <87009434+AidanBeltonS@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Similar to
gemm_batchandgemm_batch_impl, we move the#ifdef __INTEL_MKL__from thegemm_implto its wrappergemmlimiting the guard to non-supported types only. This avoids the misleading runtime error(*) withGGML_SYCL_F16on non intel device targets.(*)Error can be reproduced on master branch using NVIDIA target and enabling
GGML_SYCL_F16and running a prompt processing (-n 0) benchmark using batch > 1. Error message : "The oneAPI Math Kernel Library (oneMKL) Interfaces Project does not support this API".@NeoZhangJianyu @airMeng @AidanBeltonS @abhilash1910