Skip to content

build CI: Name artifacts#6482

Merged
phymbert merged 1 commit intoggml-org:masterfrom
EwoutH:ci-artifacts
Apr 4, 2024
Merged

build CI: Name artifacts#6482
phymbert merged 1 commit intoggml-org:masterfrom
EwoutH:ci-artifacts

Conversation

@EwoutH
Copy link
Copy Markdown
Contributor

@EwoutH EwoutH commented Apr 4, 2024

Name the artifacts in the build CI, so that they get uploaded with separate names, instead of all put into the same artifact ZIP. Example run here.

It might be possible to further simplify the packing step (in future PRs).

Solves the artifact naming conflict introduced in #6456 with the update to actions/upload-artifact v4.

Name the artifacts in the build CI, so that they get uploaded with separate names, instead of all put into the same `artifact` ZIP.

It might be possible to further simplify the packing step (in future PRs).
@phymbert phymbert merged commit c666ba2 into ggml-org:master Apr 4, 2024
@EwoutH
Copy link
Copy Markdown
Contributor Author

EwoutH commented Apr 4, 2024

Thanks for merging!

Completed run here. macOS test failure looks unrelated.

Artifacts now look like this:

image

Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
Name the artifacts in the build CI, so that they get uploaded with separate names, instead of all put into the same `artifact` ZIP.

It might be possible to further simplify the packing step (in future PRs).
phuongncn pushed a commit to phuongncn/llama.cpp-gx10-dgx-sparks-deepseekv4 that referenced this pull request Apr 28, 2026
Name the artifacts in the build CI, so that they get uploaded with separate names, instead of all put into the same `artifact` ZIP.

It might be possible to further simplify the packing step (in future PRs).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants