Skip to content

eval-callback: use ggml_op_desc to pretty print unary operator name#6631

Merged
phymbert merged 1 commit intomasterfrom
hp/eval-callback/better-name
Apr 12, 2024
Merged

eval-callback: use ggml_op_desc to pretty print unary operator name#6631
phymbert merged 1 commit intomasterfrom
hp/eval-callback/better-name

Conversation

@phymbert
Copy link
Copy Markdown
Collaborator

Context

Unary operator name was not printed.

Suggested by @slaren here: #6576 (comment)

Before:

ggml_debug:           ffn_moe_silu-0 = (f32)      UNARY(ffn_moe_gate-0{10752, 3, 1, 1}, }) = {10752, 3, 1, 1}
                                     [
                                      [
                                       [  0.0065,   4.0065,   8.0065, ...],
                                       [43008.0078, 43012.0078, 43016.0078, ...],
                                       [86016.0078, 86020.0078, 86024.0078, ...],
                                      ],
                                     ]
                                     sum = 387108.062500

After:

ggml_debug:           ffn_moe_silu-0 = (f32)       SILU(ffn_moe_gate-0{10752, 3, 1, 1}, }) = {10752, 3, 1, 1}
                                     [
                                      [
                                       [  0.0065,   4.0065,   8.0065, ...],
                                       [43008.0078, 43012.0078, 43016.0078, ...],
                                       [86016.0078, 86020.0078, 86024.0078, ...],
                                      ],
                                     ]
                                     sum = 387108.062500

@phymbert phymbert requested a review from slaren April 12, 2024 07:31
@phymbert phymbert merged commit 81da18e into master Apr 12, 2024
@phymbert phymbert deleted the hp/eval-callback/better-name branch April 12, 2024 08:26
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
phuongncn pushed a commit to phuongncn/llama.cpp-gx10-dgx-sparks-deepseekv4 that referenced this pull request Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants