convert : fix set_vocab_sentencepiece#6866
Merged
Conversation
Member
Author
|
@JustinLin610 Can you give this PR a try using codeqwen and confirm that it continues to convert correctly? |
Member
Author
|
This change should be good, right? |
mofosyne
added
Review Complexity : Low
ggerganov
commented
May 10, 2024
mofosyne
approved these changes
May 18, 2024
Collaborator
mofosyne
left a comment
mofosyne
left a comment
There was a problem hiding this comment.
checked that the logic checks out.
Looks like a refactoring kind of bugfix? If so then let's merge it in.
mofosyne
added
the
merge ready
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
* convert : fix set_vocab_sentencepiece * Update convert-hf-to-gguf.py
phuongncn
pushed a commit
to phuongncn/llama.cpp-gx10-dgx-sparks-deepseekv4
that referenced
this pull request
Apr 28, 2026
* convert : fix set_vocab_sentencepiece * Update convert-hf-to-gguf.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the same logic as in #6852 for
_set_vocab_sentencepiece()