build(cmake): simplify instructions (cmake -B build && cmake --build build ...)#6964
build(cmake): simplify instructions (cmake -B build && cmake --build build ...)#6964ochafik merged 10 commits intoggml-org:masterfrom
cmake -B build && cmake --build build ...)#6964Conversation
cmake . -B build && cmake --build build is all you need)cmake . -B build && cmake --build build is all you need)
|
The source directory defaults to the current directory when using |
Co-authored-by: Jared Van Bortel <cebtenzzre@gmail.com>
cmake . -B build && cmake --build build is all you need)cmake -B build && cmake --build build is all you need)
@cebtenzzre Neat! Updated. |
Co-authored-by: Neo Zhang Jianyu <jianyu.zhang@intel.com>
I am not sure that this is entirely correct. |
|
I just ran a quick test, and without |
…rs + document how to build Debug
@slaren Oops I misspoke, it's the default for single-generator configs (as set here), and the default is generator dependent for the others.
Thanks a lot for catching this! I just checked if setting I've reverted the |
cmake -B build && cmake --build build is all you need)cmake -B build && cmake --build build ...)
… build ...`) (ggml-org#6964) * readme: cmake . -B build && cmake --build build * build: fix typo Co-authored-by: Jared Van Bortel <cebtenzzre@gmail.com> * build: drop implicit . from cmake config command * build: remove another superfluous . * build: update MinGW cmake commands * Update README-sycl.md Co-authored-by: Neo Zhang Jianyu <jianyu.zhang@intel.com> * build: reinstate --config Release as not the default w/ some generators + document how to build Debug * build: revert more --config Release * build: nit / remove -H from cmake example * build: reword debug instructions around single/multi config split --------- Co-authored-by: Jared Van Bortel <cebtenzzre@gmail.com> Co-authored-by: Neo Zhang Jianyu <jianyu.zhang@intel.com>
… build ...`) (ggml-org#6964) * readme: cmake . -B build && cmake --build build * build: fix typo Co-authored-by: Jared Van Bortel <cebtenzzre@gmail.com> * build: drop implicit . from cmake config command * build: remove another superfluous . * build: update MinGW cmake commands * Update README-sycl.md Co-authored-by: Neo Zhang Jianyu <jianyu.zhang@intel.com> * build: reinstate --config Release as not the default w/ some generators + document how to build Debug * build: revert more --config Release * build: nit / remove -H from cmake example * build: reword debug instructions around single/multi config split --------- Co-authored-by: Jared Van Bortel <cebtenzzre@gmail.com> Co-authored-by: Neo Zhang Jianyu <jianyu.zhang@intel.com>
Updated instructions & CI to skip the
mkdir -p build && cd buildsteps using config-time flag-Band build-time flag--buildBecomes:
cmake -B build cmake --build build --config Release # --config flag is ignored for Makefile generation (default) but crucial for Release builds w/ Xcode / MSVC, as pointed out by reviewersDocumented how to do
DebugbuildsRemoved--config Releasefrom most cmake build commands (except for Visual Studio) asReleaseis the default and the--configflag is often useless anyway)Note: To build in Debug w/ CMake one generally needs to set
-DCMAKE_BUILD_TYPE=Debugin the "config" command (--config Debugon the build command works only for Ninja Multi-Config, XCode or Visual Studio generators)