BPE pretokenizer - add support for command-r-plus and command-r models#7041
Closed
sealad886 wants to merge 0 commit intoggml-org:masterfrom
sealad886:master
Closed
BPE pretokenizer - add support for command-r-plus and command-r models#7041sealad886 wants to merge 0 commit intoggml-org:masterfrom sealad886:master
sealad886 wants to merge 0 commit intoggml-org:masterfrom
sealad886:master
Conversation
Contributor
|
There is already a PR for this #7033. |
Contributor
JoanFM
reviewed
May 3, 2024
Contributor
There was a problem hiding this comment.
just curious, aren't they the exact same hash?
Collaborator
|
Is this duplicated in #7063 ? |
Contributor
|
@LostRuins Yes, this is a duplicate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Fixes #7030
Fixes #7040
Added both command-r and command-r-plus pretokenizer regex's to the model, updated the files as recommended in (120cf37).
Tests compiled at
./tests/test-tokenizer-opassed for both models.