Skip to content

Qwen/Qwen-7b HF to GGUF Conversion Support Fix#7308

Merged
ggerganov merged 1 commit intoggml-org:masterfrom
amd-lalithnc:master
May 17, 2024
Merged

Qwen/Qwen-7b HF to GGUF Conversion Support Fix#7308
ggerganov merged 1 commit intoggml-org:masterfrom
amd-lalithnc:master

Conversation

@amd-lalithnc
Copy link
Copy Markdown

Using the convert script fails with Qwen/Qwen-7b. Updating the _set_vocab_qwen function to fix the syntax errors with dictionary merge.

Copy link
Copy Markdown
Collaborator

@compilade compilade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was using the union operator for dicts (see https://peps.python.org/pep-0584/) which is only supported since Python 3.9, while gguf-py expects python = ">=3.8".

@mofosyne mofosyne added python python script changes Review Complexity : Medium Generally require more time to grok but manageable by beginner to medium expertise level labels May 16, 2024
@ggerganov ggerganov merged commit e18bc6a into ggml-org:master May 17, 2024
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
phuongncn pushed a commit to phuongncn/llama.cpp-gx10-dgx-sparks-deepseekv4 that referenced this pull request Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python python script changes Review Complexity : Medium Generally require more time to grok but manageable by beginner to medium expertise level

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants