Skip to content

[SYCL] Update SYCL upscale operation#7321

Merged
abhilash1910 merged 3 commits intoggml-org:masterfrom
AidanBeltonS:update_sycl_upscale
May 20, 2024
Merged

[SYCL] Update SYCL upscale operation#7321
abhilash1910 merged 3 commits intoggml-org:masterfrom
AidanBeltonS:update_sycl_upscale

Conversation

@AidanBeltonS
Copy link
Copy Markdown
Contributor

@AidanBeltonS AidanBeltonS commented May 16, 2024

Adds upscaling changes to SYCL backend using nearest neighbour interpolation.

Tested on PVC and A100 GPUs all upscale tests are passing.
Implementation comes from ggml-org/ggml#814

@mofosyne mofosyne added Review Complexity : Medium Generally require more time to grok but manageable by beginner to medium expertise level generation quality Quality of model output labels May 16, 2024
@NeoZhangJianyu
Copy link
Copy Markdown
Contributor

NeoZhangJianyu commented May 17, 2024

@AidanBeltonS
Could I know what's the benefit of this solution?

@mofosyne mofosyne added the SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language label May 17, 2024
@ggerganov
Copy link
Copy Markdown
Member

ggerganov commented May 17, 2024

@NeoZhangJianyu Here is more info: ggml-org/ggml#814

ggerganov
ggerganov reviewed May 17, 2024
View reviewed changes
Comment thread ggml-sycl.cpp Outdated
Comment on lines 13994 to 13995
Copy link
Copy Markdown
Member

@ggerganov ggerganov May 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These messages are no longer needed

Copy link
Copy Markdown
Contributor Author

@AidanBeltonS AidanBeltonS May 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this, I'v removed the messages

@AidanBeltonS
Copy link
Copy Markdown
Contributor Author

AidanBeltonS commented May 17, 2024

@AidanBeltonS Could I know what's the benefit of this solution?

Outside of the benefits of being able to support the application in the PR. The primary goal for myself is to get all the tests passing in test-backend-ops. This PR enables the passing of the UPSCALE op tests.

abhilash1910
abhilash1910 reviewed May 17, 2024
View reviewed changes
Comment thread ggml-sycl.cpp Outdated
@NeoZhangJianyu
Copy link
Copy Markdown
Contributor

NeoZhangJianyu commented May 17, 2024

@AidanBeltonS Could I know what's the benefit of this solution?

Outside of the benefits of being able to support the application in the PR. The primary goal for myself is to get all the tests passing in test-backend-ops. This PR enables the passing of the UPSCALE op tests.

OK, got it!

NeoZhangJianyu
NeoZhangJianyu approved these changes May 17, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@NeoZhangJianyu NeoZhangJianyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI of upscale are passed on Intel Arc770.

Comment thread ggml-sycl.cpp Outdated
@abhilash1910
Copy link
Copy Markdown
Contributor

abhilash1910 commented May 19, 2024

@AidanBeltonS could you sync master for latest changes for CI ?

@AidanBeltonS AidanBeltonS force-pushed the update_sycl_upscale branch from 663b411 to 7f5255a Compare May 20, 2024 08:10
@abhilash1910 abhilash1910 merged commit 6bf9b66 into ggml-org:master May 20, 2024
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
@AidanBeltonS
[SYCL] Update SYCL upscale operation (ggml-org#7321)
416f5a2 
* Update SYCL upscale operation

* Formatting

* Remove messages
phuongncn pushed a commit to phuongncn/llama.cpp-gx10-dgx-sparks-deepseekv4 that referenced this pull request Apr 28, 2026
@AidanBeltonS
[SYCL] Update SYCL upscale operation (ggml-org#7321)
6de307d 
* Update SYCL upscale operation

* Formatting

* Remove messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggerganov ggerganov ggerganov left review comments

@airMeng airMeng Awaiting requested review from airMeng

+2 more reviewers

@abhilash1910 abhilash1910 abhilash1910 approved these changes

@NeoZhangJianyu NeoZhangJianyu NeoZhangJianyu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

generation quality Quality of model output Review Complexity : Medium Generally require more time to grok but manageable by beginner to medium expertise level SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AidanBeltonS @NeoZhangJianyu @ggerganov @abhilash1910 @mofosyne