Skip to content

[SYCL ]add build shared lib in win release package#7438

Merged
airMeng merged 1 commit intoggml-org:masterfrom
arthw:add_build_shared_lib
May 24, 2024
Merged

[SYCL ]add build shared lib in win release package#7438
airMeng merged 1 commit intoggml-org:masterfrom
arthw:add_build_shared_lib

Conversation

@arthw
Copy link
Copy Markdown
Contributor

@arthw arthw commented May 21, 2024

add build shared lib (like llama.dll) in win release package

@arthw arthw requested a review from airMeng May 21, 2024 14:32
@mofosyne mofosyne added build Compilation issues Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix labels May 21, 2024
Copy link
Copy Markdown
Contributor

@airMeng airMeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why put it as default behavior?

cc @zhewang1-intc

@gfody
Copy link
Copy Markdown

gfody commented May 22, 2024

why put it as default behavior?

the other release packages contain llama.dll (and this makes them convenient to use them with LLamaSharp) so I thought it was unexpected that it's missing from the sycl package and opened #7361

@NeoZhangJianyu
Copy link
Copy Markdown
Contributor

why put it as default behavior?

cc @zhewang1-intc

The windows release package is used to direct user or developer who call llama.dll in other project.
I receive an issue to ask to add it: #7361.

@airMeng airMeng merged commit 0df0aa8 into ggml-org:master May 24, 2024
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
phuongncn pushed a commit to phuongncn/llama.cpp-gx10-dgx-sparks-deepseekv4 that referenced this pull request Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Compilation issues examples Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants