vulkan: initialize devices properly for LLAMA_SPLIT_MODE_NONE#7552
Merged
0cc4m merged 1 commit intoggml-org:masterfrom May 28, 2024
Merged
vulkan: initialize devices properly for LLAMA_SPLIT_MODE_NONE#75520cc4m merged 1 commit intoggml-org:masterfrom
0cc4m merged 1 commit intoggml-org:masterfrom
Conversation
Contributor
Member
|
Should be fixed on the vulkan backend instead. |
bd00902 to
c61e8e9
Compare
c61e8e9 to
ee84384
Compare
Contributor
Author
Ok, changed it. |
ee84384 to
40c8d7f
Compare
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
phuongncn
pushed a commit
to phuongncn/llama.cpp-gx10-dgx-sparks-deepseekv4
that referenced
this pull request
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Before the change, split mode "none" doesn't work for vulkan because it is not properly initialized before offload:
gives an error.
This is because vulkan backend is initialized here
https://github.com/ggerganov/llama.cpp/blob/d6ef0e77dd25f54fb5856af47e3926cf6f36c281/ggml-vulkan.cpp#L6014-L6024
which is being called in
llama_get_device_count, andllama_get_device_countis not being called when split mode is "none"This PR makellm_load_tensorsto callllama_get_device_counteven when split mode is "none".Something worth thinking about, is relying onllama_get_device_countto initialize vulkan backend a good idea? Feels like this is a bit cryptic.