use the correct SYCL context for host USM allocations#7777
Merged
AidanBeltonS merged 1 commit intoggml-org:masterfrom Jun 10, 2024
Merged
use the correct SYCL context for host USM allocations#7777AidanBeltonS merged 1 commit intoggml-org:masterfrom
AidanBeltonS merged 1 commit intoggml-org:masterfrom
Conversation
Signed-off-by: Ben Ashbaugh <ben.ashbaugh@intel.com>
Contributor
|
Hey @bashbaug thanks for submitting this. It looks good, just running some tests internally & will get back to you 👍 |
AidanBeltonS
approved these changes
Jun 6, 2024
Contributor
AidanBeltonS
left a comment
There was a problem hiding this comment.
Thanks for fixing this bug!
NeoZhangJianyu
approved these changes
Jun 7, 2024
Contributor
NeoZhangJianyu
left a comment
There was a problem hiding this comment.
It's great!
Thank you fix it!
AidanBeltonS
added a commit
that referenced
this pull request
Jun 10, 2024
This reverts commit af4ae50.
4 tasks
2 tasks
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
Signed-off-by: Ben Ashbaugh <ben.ashbaugh@intel.com>
phuongncn
pushed a commit
to phuongncn/llama.cpp-gx10-dgx-sparks-deepseekv4
that referenced
this pull request
Apr 28, 2026
Signed-off-by: Ben Ashbaugh <ben.ashbaugh@intel.com>
ljubomirj
pushed a commit
to ljubomirj/llama.cpp
that referenced
this pull request
May 6, 2026
Signed-off-by: Ben Ashbaugh <ben.ashbaugh@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I found an issue testing SYCL with the OpenCL backend: the SYCL host USM allocations are happening against a different queue (and hence a different context) than the other allocations, which is undefined behavior according to the SYCL spec:
The specific error I am seeing is:
The changes in this PR are intended to use the same queue for USM host allocations as for other allocations, which works for both the OpenCL backend and the Level Zero backend (tested with an Intel integrated GPU and an Intel discrete GPU).
Specifically, I tested with:
Both backends generated the same results.