Fixed packages version problem + fixed problem with convert-hf-to-gguf-update.py#7925
Closed
hamdoudhakem wants to merge 1 commit intoggml-org:masterfrom
Closed
Fixed packages version problem + fixed problem with convert-hf-to-gguf-update.py#7925hamdoudhakem wants to merge 1 commit intoggml-org:masterfrom
hamdoudhakem wants to merge 1 commit intoggml-org:masterfrom
Conversation
-Changed the numby and torch versions to newer ones - Specified the encoding when reading and writing on the convert-hf-to-gguf.py file from the convert-hf-to-gguf-update.py file
Contributor
|
Could you split it into 2 separate PRs? One for requirements other for encoding. I tested dependency bump and it seems to work both on python 3.11 and python 3.12, so looks like we're good there. Please ping me if/when you open them so I'll approve them quicker. |
This was referenced Jun 20, 2024
Contributor
Author
I created 2 new PRs like you suggested here are the links :
|
Contributor
|
Thanks, I merged them, so we can close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR make minor changes ro a few things including the version of some packages :
requirements.txt2.1.1didn't exist and proposed other versions like2.2.0,2.2.1, etcand also the
convert-hf-to-gguf-update.pywas updated to useencoding="utf-8"when reading and writing onconvert-hf-to-gguf.pybecause some characters kept breaking the execution of theconvert-hf-to-gguf-update.py(mostly hexadecimal characters that weren't recognized under windows default encoding) like the rocket emojis "🚀"