SimpleChat v3.1: Boolean chat request options in Settings UI, cache_prompt#7950
Conversation
mofosyne
added
the
Review Complexity : Low
|
Hi @mofosyne I will push few more commits in an hours time, to clean up the settings entries to match a logical flow, rather than the current sequence which came about, more based on when things were added into it. Also rename chatRequestOptions to apiRequestOptions, to indicate that it is used for both chat/completions and completions api end points. |
|
Hi @mofosyne this PR is done, you can merge this. |
akx
left a comment
akx
left a comment
There was a problem hiding this comment.
I don't think it's necessarily a great idea to add a 140 KB, 1200 × 720 screenshot...
|
have changed to webp image format and also resized to 800x480, so now it occupies only 20K. Added the image to give a rough idea of how it will be, if one wants to use it. |
Show the chat screen and the settings screen
Make it more logically structured and flow through.
So that it is not wrongly assumed that these request options are used only for chat/completions endpoint. Rather these are used for both the end points, so rename to match semantic better.
hanishkvc
force-pushed
the
hkvc_webfrontend_simplechat_v3.1
branch
from
6c0d43c to
ed762f8
Compare
|
Hi @mofosyne The failing check was not related to simplechat nor this pr. Eitherway I have force rebased to the latest upstream. |
|
@ggerganov seems like multiple PRs are constantly getting out-of-date with the base branch even if all the checks has passed. Rebasing and waiting for the checks doesn't seem to clear it in time as another PR would have been merged and then the cycle needs to start again. |
mofosyne
added
the
merge ready
|
I had accidentally enabled the following setting:
Disabled now and should be good |
…rompt (ggml-org#7950) * SimpleChat: Allow for chat req bool options to be user controlled * SimpleChat: Allow user to control cache_prompt flag in request * SimpleChat: Add sample GUI images to readme file Show the chat screen and the settings screen * SimpleChat:Readme: Add quickstart block, title to image, cleanup * SimpleChat: RePosition contents of the Info and Settings UI Make it more logically structured and flow through. * SimpleChat: Rename to apiRequestOptions from chatRequestOptions So that it is not wrongly assumed that these request options are used only for chat/completions endpoint. Rather these are used for both the end points, so rename to match semantic better. * SimpleChat: Update image included with readme wrt settings ui * SimpleChat:ReadMe: Switch to webp screen image to reduce size
…rompt (ggml-org#7950) * SimpleChat: Allow for chat req bool options to be user controlled * SimpleChat: Allow user to control cache_prompt flag in request * SimpleChat: Add sample GUI images to readme file Show the chat screen and the settings screen * SimpleChat:Readme: Add quickstart block, title to image, cleanup * SimpleChat: RePosition contents of the Info and Settings UI Make it more logically structured and flow through. * SimpleChat: Rename to apiRequestOptions from chatRequestOptions So that it is not wrongly assumed that these request options are used only for chat/completions endpoint. Rather these are used for both the end points, so rename to match semantic better. * SimpleChat: Update image included with readme wrt settings ui * SimpleChat:ReadMe: Switch to webp screen image to reduce size
4 participants
Allow user to control any boolean options in the request json sent to server, from the settings ui.
Using same allow cache_prompt to be enabled, if the user so wants.