Skip to content

enable curl in nix build#8043

Merged
ggerganov merged 3 commits intoggml-org:masterfrom
edude03:chore/enable-curl-option
Jul 1, 2024
Merged

enable curl in nix build#8043
ggerganov merged 3 commits intoggml-org:masterfrom
edude03:chore/enable-curl-option

Conversation

@edude03
Copy link
Copy Markdown
Contributor

@edude03 edude03 commented Jun 20, 2024

Enables curl support in the nix build of llama.cpp, which I noticed was disabled when I tried to pull a model from hugging face.

@github-actions github-actions Bot added nix Issues specific to consuming flake.nix, or generally concerned with ❄ Nix-based llama.cpp deployment devops improvements to build systems and github actions labels Jun 20, 2024
@mofosyne mofosyne added the Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix label Jun 21, 2024
Comment thread .devops/nix/package.nix
(cmakeBool "LLAMA_METAL" useMetalKit)
(cmakeBool "LLAMA_VULKAN" useVulkan)
(cmakeBool "LLAMA_STATIC" enableStatic)
(cmakeBool "LLAMA_CURL" enableCurl)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks, would you have the time to resolve the merge conflicts?

@ggerganov ggerganov merged commit 3840b6f into ggml-org:master Jul 1, 2024
MagnusS0 pushed a commit to MagnusS0/llama.cpp-normistral-tokenizer that referenced this pull request Jul 1, 2024
Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops improvements to build systems and github actions nix Issues specific to consuming flake.nix, or generally concerned with ❄ Nix-based llama.cpp deployment Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants