[SYCL] Fix WARP_SIZE=16 bug of Intel GPU#8266
Merged
airMeng merged 8 commits intoggml-org:masterfrom Jul 5, 2024
Merged
Conversation
airMeng
approved these changes
Jul 3, 2024
Contributor
NeoZhangJianyu
approved these changes
Jul 3, 2024
Contributor
NeoZhangJianyu
left a comment
There was a problem hiding this comment.
It's passed on MTL after I test.
Collaborator
|
Tested iq4_XS, Q4_K_S. LGTM |
Contributor
Author
|
@qnixsynapse Thanks for your test! Q4_K models still use WARP_SIZE=32, so they won't benefit from this PR. |
Collaborator
|
@luoyu-intel Yes, I am aware. I am testing IQ4 models currently. |
Collaborator
|
@joeatodd @OuadiElfarouki Performance of the SYCL branch using an NVIDIA A100 with Q4_K has no regressions.
build: 4887fdce (3293)
build: 4887fdce (3293) |
arthw
added a commit
to arthw/llama.cpp
that referenced
this pull request
Jul 13, 2024
[SYCL] Fix WARP_SIZE=16 bug of Intel GPU (ggml-org#8266) * fix group_norm ut * split softmax * fix softmax * add concat support condition * revert debug code * move QK_WARP_SIZE to presets.hpp Fix issue in above PR: fix norm() nullptr lead to crash on iGPU. use WARP_32_SIZE replace QK_WARP_SIZE optimize dmmv.cpp for iGPU. add sycl_hw.cpp to detect Hardware info.
4 tasks
arthw
added a commit
to arthw/llama.cpp
that referenced
this pull request
Jul 13, 2024
[SYCL] Fix WARP_SIZE=16 bug of Intel GPU (ggml-org#8266) cherry-pick b549a1b
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
* fix group_norm ut * split softmax * fix softmax * add concat support condition * revert debug code * move QK_WARP_SIZE to presets.hpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes some bugs of WARP_SIZE=16 for Intel GPU. All warp-related UTs are passed.
WARP_SIZE=16 has the same output as WARP_SIZE=32 on Intel GPUs.
NOTE: QX_K kernels are specialized for WARP_SIZE=32, so I use a fixed WARP_SIZE for them.
Performance change
llama-2-7b-chat-hf-q4_0.gguf, 32 in and 32 out, on ARC A770, from 40 tokens/s to 44 tokens/s
Master Branch
PR Branch