Skip to content

llama : add early return for empty range #8327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggerganov merged 4 commits into from
Jul 6, 2024
Merged

llama : add early return for empty range #8327

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f341bd6
llama : add early return for empty range
danbev Jul 5, 2024
4eb8073
llama : add static_cast to fix CI warning/error
danbev Jul 5, 2024
eb572f9
squash! llama : add early return for empty range
danbev Jul 5, 2024
c9d6700
Update src/llama.cpp
ggerganov Jul 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/llama.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3258,6 +3258,8 @@ static void llama_kv_cache_seq_add(

if (p0 < 0) p0 = 0;
if (p1 < 0) p1 = std::numeric_limits<llama_pos>::max();
// If there is no range then return early to avoid looping over the cache.
if (p0 == p1) return;

if (cache.recurrent) {
// for Mamba-like models, only the pos needs to be shifted
Expand Down Expand Up @@ -3302,6 +3304,8 @@ static void llama_kv_cache_seq_div(
int d) {
if (p0 < 0) p0 = 0;
if (p1 < 0) p1 = std::numeric_limits<llama_pos>::max();
// If there is no range then return early to avoid looping over the cache.
if (p0 == p1) return;

if (cache.recurrent) {
// for Mamba-like models, only the pos needs to be changed
Expand Down