Skip to content

Fix Safari Compatibility Issue: Replace URL.parse Method in llama-server UI#8646

Merged
ggerganov merged 1 commit intoggml-org:masterfrom
0x4139:master
Jul 23, 2024
Merged

Fix Safari Compatibility Issue: Replace URL.parse Method in llama-server UI#8646
ggerganov merged 1 commit intoggml-org:masterfrom
0x4139:master

Conversation

@0x4139
Copy link
Copy Markdown
Contributor

@0x4139 0x4139 commented Jul 23, 2024 •
edited
Loading

The URL.parse method is not available in all browsers, particularly Safari, which causes the UI interface for llama-server to break. This pull request replaces the URL.parse method with the new URL() constructor to ensure compatibility across all browsers. Using new URL() provides a more standardized and widely supported way to parse URLs, resolving the issue with Safari and improving overall browser compatibility.

Fixes #8631

ggerganov
ggerganov approved these changes Jul 23, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@ggerganov ggerganov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think this is this related to #8631?

@0x4139
Copy link
Copy Markdown
Contributor Author

0x4139 commented Jul 23, 2024 •
edited
Loading

Do you think this is this related to #8631?

Yes, one of the users mentions that the web UI works on chromium, so it's definitely a compatibility issue. It also seems that the bug was introduced in #8552

@auriocus auriocus mentioned this pull request Jul 23, 2024
Closed
@ScarletEmerald ScarletEmerald mentioned this pull request Jul 23, 2024
Merged
4 tasks
@ggerganov ggerganov merged commit b841d07 into ggml-org:master Jul 23, 2024
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Jul 27, 2024
@0x4139 @arthw
server : fix URL.parse in the UI (ggml-org#8646)
b7e8bad
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
@0x4139
server : fix URL.parse in the UI (ggml-org#8646)
8775389
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggerganov ggerganov ggerganov approved these changes

Assignees

No one assigned

Labels

examples server

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: server is broken by Mistral Nemo commit

2 participants

@0x4139 @ggerganov