export-lora : fix issue with quantized base models#8687
Merged
ngxson merged 1 commit intoggml-org:masterfrom Jul 25, 2024
Merged
export-lora : fix issue with quantized base models#8687ngxson merged 1 commit intoggml-org:masterfrom
ngxson merged 1 commit intoggml-org:masterfrom
Conversation
slaren
approved these changes
Jul 25, 2024
Member
slaren
left a comment
There was a problem hiding this comment.
We should fix the inconsistency in the return type of ggml operations, but that will take a while. Maybe for ggml 2.0. This will do for now.
Contributor
Author
|
Yeah right. In addition to that, I think we can add an option |
Member
|
@ngxson We should add some lightweight tests of the lora functionality |
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Jul 27, 2024
Collaborator
|
I think there may be a problem related to this PR: #8974 |
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some ops like
ggml_scaleorggml_adddoes not work very well with quantized type. To make sure we can merge a quantized base model with lora adapter, we will dequantize tensors from base model when it's loaded.Related to discussion: #8663 (comment)
Test: