Skip to content

Add missing pthread includes on FreeBSD#9258

Merged
ggerganov merged 1 commit intoggml-org:masterfrom
yurivict:missing-includes
Sep 2, 2024
Merged

Add missing pthread includes on FreeBSD#9258
ggerganov merged 1 commit intoggml-org:masterfrom
yurivict:missing-includes

Conversation

@yurivict
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot added the ggml changes relating to the ggml tensor library for machine learning label Aug 31, 2024
@ngxson
Copy link
Copy Markdown
Contributor

ngxson commented Aug 31, 2024

I don't see any benefit of this change. pthread is already included in another line:

https://github.com/ggerganov/llama.cpp/blob/121f915a09c1117d34aff6e8faf6d252aaf11027/ggml/src/ggml.c#L149

And pthread_np clearly does not exist outside of BSD, which breaks all the builds on the CI

@yurivict yurivict changed the title Add missing pthread includes Add missing pthread includes on FreeBSD Sep 1, 2024
@yurivict
Copy link
Copy Markdown
Contributor Author

yurivict commented Sep 1, 2024

Sorry, I adjusted the patch.

The missing include is pthread_np.h on FreeBSD.

@ggerganov ggerganov merged commit f771d06 into ggml-org:master Sep 2, 2024
dsx1986 pushed a commit to dsx1986/llama.cpp that referenced this pull request Oct 29, 2024
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 15, 2024
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 18, 2024
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ggml changes relating to the ggml tensor library for machine learning

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants