llama : set attrs of mislabelled EOT/EOM tokens#9348
Merged
ggerganov merged 1 commit intoggml-org:masterfrom Sep 8, 2024
Merged
llama : set attrs of mislabelled EOT/EOM tokens#9348ggerganov merged 1 commit intoggml-org:masterfrom
ggerganov merged 1 commit intoggml-org:masterfrom
Conversation
dsx1986
pushed a commit
to dsx1986/llama.cpp
that referenced
this pull request
Oct 29, 2024
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 15, 2024
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 18, 2024
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some models (such as the official phi-3-mini-4k-instruct-gguf) have an
<|end|>or similar token which is detected as being EOT or EOM but which is not marked as control.This causes issues where the token will be included in the output when it shouldn't. A complete reproduction is to install the phi-3-mini-4k-instruct-gguf linked above and then run
which will print
animal<|end|>.In these cases, manually set the token's
attrtoLLAMA_TOKEN_ATTR_CONTROLso that we know not to print it. That fixes the above repro to correctly print justanimal.