Skip to content

main: option to disable context shift#9484

Merged
ggerganov merged 11 commits intoggml-org:masterfrom
VJHack:server-disable-context-shift
Sep 16, 2024
Merged

main: option to disable context shift#9484
ggerganov merged 11 commits intoggml-org:masterfrom
VJHack:server-disable-context-shift

Conversation

@VJHack
Copy link
Copy Markdown
Contributor

@VJHack VJHack commented Sep 14, 2024

Added the option to disable context shift on infinite text generation with command line argument (--no-context-shift) for llama-cli.

@VJHack
Copy link
Copy Markdown
Contributor Author

VJHack commented Sep 14, 2024

Partly addresses #9390

Comment thread common/arg.cpp Outdated
@VJHack
Copy link
Copy Markdown
Contributor Author

VJHack commented Sep 16, 2024

@ggerganov Thanks for the review! I resolved some merge conflicts and removed the server.cpp changes. I'll tackle applying --no-context-shift to the server in a subsequent PR.

@ggerganov ggerganov merged commit 441b72b into ggml-org:master Sep 16, 2024
@VJHack VJHack deleted the server-disable-context-shift branch September 17, 2024 02:10
dsx1986 pushed a commit to dsx1986/llama.cpp that referenced this pull request Oct 29, 2024
* added cli arg to disable context shift

* reverted precommit

* updated README.md for main

* white space

* allow disabling context shift in the server

* Update common/arg.cpp

no-context-shift only works for main example

Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>

* added server example to --no-context-shift args

* removed server changes

* white space

---------

Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 15, 2024
* added cli arg to disable context shift

* reverted precommit

* updated README.md for main

* white space

* allow disabling context shift in the server

* Update common/arg.cpp

no-context-shift only works for main example

Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>

* added server example to --no-context-shift args

* removed server changes

* white space

---------

Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 18, 2024
* added cli arg to disable context shift

* reverted precommit

* updated README.md for main

* white space

* allow disabling context shift in the server

* Update common/arg.cpp

no-context-shift only works for main example

Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>

* added server example to --no-context-shift args

* removed server changes

* white space

---------

Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
* added cli arg to disable context shift

* reverted precommit

* updated README.md for main

* white space

* allow disabling context shift in the server

* Update common/arg.cpp

no-context-shift only works for main example

Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>

* added server example to --no-context-shift args

* removed server changes

* white space

---------

Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants