Imatrix input data should not be unescaped#9543
Merged
ggerganov merged 1 commit intoggml-org:masterfrom Sep 19, 2024
Merged
Conversation
ggerganov
approved these changes
Sep 19, 2024
Member
|
perplexity will probably need a similar fix. |
Member
Author
|
@slaren I'll make another PR for |
2 tasks
dsx1986
pushed a commit
to dsx1986/llama.cpp
that referenced
this pull request
Oct 29, 2024
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 15, 2024
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 18, 2024
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At some point prompt input unescaping was turned on by default, which is fine in itself, but imatrix is usually generated from
prompt_file, which is fed intoparams.promptand then unescaped, generating bad input data.This will (and has) go(ne) unnoticed until you have sequences like
\xdefin your input data, which will throw an "invalid character" error (only with BPE tokenizer).