Added a bool fold_lowercase to whisper_context_params#2005
Added a bool fold_lowercase to whisper_context_params#2005ulatekh wants to merge 5 commits intoggml-org:masterfrom
Conversation
If true, it folds language-model tokens to lowercase. By default, it's false. This is intended to make grammar matching more predictable, e.g. no need to account for case in the grammar.
| bool print_energy = false; | ||
| bool no_timestamps = true; | ||
| bool use_gpu = true; | ||
| bool model_fold_lc = false; |
Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
| fprintf(stderr, " -nt, --no-timestamps [%-7s] do not print timestamps\n", params.no_timestamps ? "true" : "false"); | ||
| fprintf(stderr, " --model-fold-lc [%-7s] fold all model tokens to lowercase\n", params.model_fold_lc ? "true" : "false"); |
There was a problem hiding this comment.
| fprintf(stderr, " -nt, --no-timestamps [%-7s] do not print timestamps\n", params.no_timestamps ? "true" : "false"); | |
| fprintf(stderr, " --model-fold-lc [%-7s] fold all model tokens to lowercase\n", params.model_fold_lc ? "true" : "false"); | |
| fprintf(stderr, " -nt, --no-timestamps [%-7s] do not print timestamps\n", params.no_timestamps ? "true" : "false"); | |
| fprintf(stderr, " --vocab-lc [%-7s] fold all vocab tokens to lowercase\n", params.vocab_lc ? "true" : "false"); |
|
I have no idea what's wrong with the Java bindings. I loaded them all into Visual Studio Code and fixed all the errors it reported (which didn't seem related to my changes), but still the Java-related tests fail. FYI, I haven't programmed in Java in over 10 years. |
|
I'm also not good with Java, but I think we are probably observing an issue similar to this one: ggml-org/llama.cpp#1902 (comment) In short, even though the two structs The proper solution is to order the members in decreasing size (i.e. keep the bools at the end of the struct). Or maybe avoid |
If true, it folds language-model tokens to lowercase. By default, it's false.
This is intended to make grammar matching more predictable, e.g. no need to account for case in the grammar.