BUGFIX: 3-arg subtraction was not implemented#103
Open
jjgross77 wants to merge 2 commits intogh-training:mainfrom
Open
BUGFIX: 3-arg subtraction was not implemented#103jjgross77 wants to merge 2 commits intogh-training:mainfrom
jjgross77 wants to merge 2 commits intogh-training:mainfrom
Conversation
jjgross77
commented
Nov 30, 2023
| # Make sure 4 - 3 = 1 | ||
| self.assertEqual(sub(4, 3), 1, 'subtracting three from four') | ||
|
|
||
| def test_sub_3arg(self): |
Author
There was a problem hiding this comment.
Are there any edge cases I had forgotten?
Adding support for 3rd arg
jjgross77
commented
Nov 30, 2023
| return a + b + third_operand | ||
|
|
||
| def sub(a, b): | ||
| def sub(a, b, c = 0): |
Author
There was a problem hiding this comment.
Suggested change
| def sub(a, b, c = 0): | |
| def sub(a, b, q = 0): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are adding this as promised