Skip to content

Docker-machine addred suport to Vsphere for extra arument #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gijzelaerr merged 3 commits into from
Jan 25, 2018
+5 −2
Merged

Docker-machine addred suport to Vsphere for extra arument #11

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cdc3e67
Added suport to extra parameter suport to create()
Jan 12, 2018
d1b3b9e
- Argumenst passed to docker-machine just be added before specifying
Jan 24, 2018
757ddc2
Xarg createVM : Removed Mutable Default Arguments
gjagtap Jan 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions machine/machine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def version(self):
match = self._match(cmd, regexp)
return match.group(1)

def create(self, name, driver='virtualbox', blocking=True):
def create(self, name, driver='virtualbox', blocking=True, xarg=None):
"""
Create a docker machine using the provided name and driver
NOTE: This takes a loooooong time
Expand All @@ -99,7 +99,10 @@ def create(self, name, driver='virtualbox', blocking=True):
Returns:
int: error code from the run
"""
cmd = ['create', '--driver', driver, name]
if xarg is None:
xarg = []
cmd = ['create', '--driver', driver] + xarg + [name]

if blocking:
stdout, stderr, errorcode = self._run_blocking(cmd)
else:
Expand Down