Add blocking docker create#6
Merged
Merged
Conversation
Owner
|
awesome! looking good. Can you maybe extend the test suite so it tests the create command both blocking and not-blocking? |
Contributor
Author
|
On it ;) |
Contributor
Author
|
Good enough ? |
Owner
|
perfect! |
Owner
|
made a new 0.2.2 release! |
Contributor
Author
|
Great :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for the docker create command.
It takes forever so that is why I added a _run_blocking definition, using the blocking approach is triggered by the blocking argument.