Skip to content

Conversation

@hedgehog125
Copy link

@hedgehog125 hedgehog125 commented Nov 23, 2025

Fixes the issues I describe in #4451

Some questions:

  • Is this considered a breaking change? It changes some behaviour but mostly fixes it
  • Are the subtleties of this correct? I adapted http.Dir but maybe we want to implement the slightly simpler fix in http.FileServer instead?
  • Should the test use embedding? I'm copying gin-contrib/static a bit, but that makes it a bit more realistic?

Pull Request Checklist

Please ensure your pull request meets the following requirements:

  • [ ✔️ ] Open your pull request against the master branch.
  • [ ❌ ] All tests pass in available continuous integration systems (e.g., GitHub Actions).
    • I think there might be some issues with the CI?
  • [ ✔️ ] Tests are added or modified as needed to cover code changes.
  • [ N/A ] If the pull request introduces a new feature, the feature is documented in the docs/doc.md.

Thank you for contributing!

@hedgehog125 hedgehog125 marked this pull request as ready for review November 23, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant