Skip to content

yaml float handling#22

Merged
gipert merged 8 commits into
gipert:mainfrom
ggmarshall:main
Mar 9, 2025
Merged

yaml float handling#22
gipert merged 8 commits into
gipert:mainfrom
ggmarshall:main

Conversation

@ggmarshall
Copy link
Copy Markdown
Contributor

Annoying thing in pyyaml where 5e-6 would be read in as a str instead of a float, seems to be fixed but no release yet see: yaml/pyyaml#555 , this just adds a custom writer to add the decimal point so floats will be read correctly, maybe a better way to handle this though

@gipert
Copy link
Copy Markdown
Owner

gipert commented Mar 9, 2025

a unit test would be easy and useful also for the future...

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 9, 2025

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.60%. Comparing base (8df6472) to head (81c3451).
Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
src/dbetto/utils.py 87.50% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   83.10%   91.60%   +8.49%     
==========================================
  Files           6        6              
  Lines         444      536      +92     
==========================================
+ Hits          369      491     +122     
+ Misses         75       45      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread tests/test_utils.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants