Fix MSVC/Visual Studio build #1957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
after adjusting the MSVC linker flags to force it to use wmain(). Noticed by Ben Peart. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
…ersions Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
benpeart
approved these changes
Nov 27, 2018
benpeart
left a comment
benpeart
left a comment
There was a problem hiding this comment.
I've tested this version and it solved the problem. Thanks!
dscho
added a commit
to dscho/git
that referenced
this pull request
Nov 27, 2018
Fix MSVC/Visual Studio build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, the recent restructuring of the environment handling had an unexpected fallout: the
wmain()function was not actually used in the MSVC build, but themain()function was picked up instead, and therefore not only was the environment not handled as we wanted, but the_wpgmptrvariable was initialized toNULLand not pointing to the absolute path of the current executable, causing a segmentation fault (reported by @benpeart).This PR fixes that.