Do not mistake COM0 for a reserved file name
#2473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 4dc42c6 (mingw: refuse paths containing reserved names, 2019-12-21), we started disallowing file names that are reserved, e.g. `NUL`, `CONOUT$`, etc. This included `COM<n>` where `<n>` is a digit. Unfortunately, this includes `COM0` but only `COM1`, ..., `COM9` are reserved, according to the official documentation, `COM0` is mentioned in the "NT Namespaces" section but it is explicitly _omitted_ from the list of reserved names: https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file#naming-conventions Tests corroborate this: it is totally possible to write a file called `com0.c` on Windows 10, but not `com1.c`. So let's tighten the code to disallow only the reserved `COM<n>` file names, but to allow `COM0` again. This fixes git-for-windows#2470. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 16, 2020
Do not mistake `COM0` for a reserved file name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 16, 2020
Do not mistake `COM0` for a reserved file name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 16, 2020
Do not mistake `COM0` for a reserved file name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 17, 2020
Do not mistake `COM0` for a reserved file name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 17, 2020
Do not mistake `COM0` for a reserved file name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 17, 2020
Do not mistake `COM0` for a reserved file name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 17, 2020
Do not mistake `COM0` for a reserved file name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 22, 2020
Do not mistake `COM0` for a reserved file name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 22, 2020
Do not mistake `COM0` for a reserved file name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 22, 2020
Do not mistake `COM0` for a reserved file name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 22, 2020
Do not mistake `COM0` for a reserved file name
dscho
added a commit
that referenced
this pull request
Jan 23, 2020
Do not mistake `COM0` for a reserved file name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 24, 2020
Do not mistake `COM0` for a reserved file name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 24, 2020
Do not mistake `COM0` for a reserved file name
dscho
added a commit
that referenced
this pull request
Jan 24, 2020
Do not mistake `COM0` for a reserved file name
dscho
added a commit
that referenced
this pull request
Jan 24, 2020
Do not mistake `COM0` for a reserved file name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 27, 2020
Do not mistake `COM0` for a reserved file name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 27, 2020
Do not mistake `COM0` for a reserved file name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 27, 2020
Do not mistake `COM0` for a reserved file name
dscho
added a commit
that referenced
this pull request
Jan 28, 2020
Do not mistake `COM0` for a reserved file name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 29, 2020
Do not mistake `COM0` for a reserved file name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 29, 2020
Do not mistake `COM0` for a reserved file name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 7, 2020
Do not mistake `COM0` for a reserved file name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 7, 2020
Do not mistake `COM0` for a reserved file name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 7, 2020
Do not mistake `COM0` for a reserved file name
dscho
added a commit
that referenced
this pull request
Apr 8, 2020
Do not mistake `COM0` for a reserved file name
dscho
added a commit
that referenced
this pull request
Apr 8, 2020
Do not mistake `COM0` for a reserved file name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 8, 2020
Do not mistake `COM0` for a reserved file name
dscho
added a commit
that referenced
this pull request
Apr 8, 2020
Do not mistake `COM0` for a reserved file name
dscho
added a commit
that referenced
this pull request
Apr 8, 2020
Do not mistake `COM0` for a reserved file name
dscho
added a commit
that referenced
this pull request
Apr 9, 2020
Do not mistake `COM0` for a reserved file name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 14, 2020
Do not mistake `COM0` for a reserved file name
derrickstolee
pushed a commit
to microsoft/git
that referenced
this pull request
Apr 14, 2020
…rved-name Do not mistake `COM0` for a reserved file name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 14, 2020
Do not mistake `COM0` for a reserved file name
dscho
added a commit
that referenced
this pull request
Apr 17, 2020
Do not mistake `COM0` for a reserved file name
dscho
added a commit
that referenced
this pull request
Apr 18, 2020
Do not mistake `COM0` for a reserved file name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 20, 2020
Do not mistake `COM0` for a reserved file name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 20, 2020
Do not mistake `COM0` for a reserved file name
derrickstolee
pushed a commit
to microsoft/git
that referenced
this pull request
Apr 20, 2020
…rved-name Do not mistake `COM0` for a reserved file name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 24, 2020
Do not mistake `COM0` for a reserved file name
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 1, 2020
Do not mistake `COM0` for a reserved file name
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 9, 2020
Do not mistake `COM0` for a reserved file name
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 15, 2020
Do not mistake `COM0` for a reserved file name
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 29, 2020
Do not mistake `COM0` for a reserved file name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2470.