Skip to content

feat: fetch all repo PRs instead of just open PRs#41

Merged
tranhl merged 4 commits intomainfrom
use-pull-request-target
Oct 31, 2024
Merged

feat: fetch all repo PRs instead of just open PRs#41
tranhl merged 4 commits intomainfrom
use-pull-request-target

Conversation

@tranhl
Copy link
Collaborator

@tranhl tranhl commented Oct 31, 2024

Description

Fixes #13

Decided to fetch all PRs instead of open ones because:

  • The action can fail on closed PRs as well, not just merged PRs.
  • It's not possible to request merged PRs via the pulls REST API. We'd need to call Check if a pull request has been merged instead, which is more trouble than it's worth.

Stack

@tranhl tranhl closed this Oct 31, 2024
@tranhl tranhl reopened this Oct 31, 2024
@tranhl tranhl changed the title Use pull_request_target event for actions feat: fetch all repo PRs instead of just open PRs Oct 31, 2024
@tranhl tranhl merged commit 219de3c into main Oct 31, 2024
@tranhl tranhl deleted the use-pull-request-target branch October 31, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

False error when PR is merged before action runs

2 participants

Comments