Services: Add service to finder contextual menu. #583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lolgear
commented
Sep 17, 2019
lolgear
commented
- Feature Request: Open GitUp from finder context menu #287
Contributor
Author
|
@lucasderraugh Awaiting for review :) |
GitUp/Application/ServicesProvider.m
Outdated
| [self.appDelegate _openRepositoryWithURL:url withCloneMode:kCloneMode_None windowModeID:NSNotFound]; | ||
| } | ||
| else { | ||
| // fill error if needed. |
Collaborator
There was a problem hiding this comment.
Can we report back if the item doesn't contain a git repository?
Contributor
Author
There was a problem hiding this comment.
@lucasderraugh Sure.
Does this check exist in GCRepository?
Contributor
Author
|
@lucasderraugh |
Contributor
Author
|
@lucasderraugh |
2 tasks
Contributor
Author
|
Ready? |
Contributor
Author
|
@lucasderraugh Ready? |
Collaborator
|
Looks good. Sorry for taking forever to review this 😬. |
simpzan
pushed a commit
to simpzan/GitUp
that referenced
this pull request
Oct 22, 2020
* application: services provider has been added. * application: app delegate services provider has been registered. * application: services provider notes have been added. * application: info plist service have been added. * Fix spelling mistake * application: services provider check for existing repository has been added. * application: services provider imports have been fixed. Co-authored-by: Lucas Derraugh <lucas@derraugh.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.