Skip to content

ci: build and test with Python 2 and 3; the cheap way #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
szeder wants to merge 3 commits into from
Closed

ci: build and test with Python 2 and 3; the cheap way #538

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c14d98
ci: also run linux-gcc pipeline with python3.5 environment
yangskyboxlabs Dec 13, 2019
a08c429
Revert "ci: also run linux-gcc pipeline with python3.5 environment"
szeder Jan 23, 2020
2a569f8
ci: build and test with Python 2 and 3; the cheap way
szeder Jan 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ci/lib.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,9 @@ linux-clang|linux-gcc)
if [ "$jobname" = linux-gcc ]
then
export CC=gcc-8
MAKEFLAGS="$MAKEFLAGS PYTHON_PATH=$(which python3)"
else
MAKEFLAGS="$MAKEFLAGS PYTHON_PATH=$(which python2)"
fi

export GIT_TEST_HTTPD=true
Expand All @@ -182,6 +185,9 @@ osx-clang|osx-gcc)
if [ "$jobname" = osx-gcc ]
then
export CC=gcc-9
MAKEFLAGS="$MAKEFLAGS PYTHON_PATH=$(which python3)"
else
MAKEFLAGS="$MAKEFLAGS PYTHON_PATH=$(which python2)"
Copy link
Member

@dscho dscho Jan 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only objection I have is that it is already pretty magic to anybody who was not involved in the development of our CI/PR pipeline where and how the different axes are tested. This exacerbates that problem... How are people to know that the -gcc axis is intended to test with Python 3.x whereas the -clang ones are intended to test with Python 2.x?

fi

# t9810 occasionally fails on Travis CI OS X
Expand Down