Pr/fredi/cleanup and validation #1245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fredi-raspall
force-pushed
the
pr/fredi/cleanup-and-validation
branch
3 times, most recently
from
490ea17 to
15bb24c
Compare
Signed-off-by: Fredi Raspall <fredi@githedgehog.com>
For some reason, the method was made to return a ConfigResult, which is unnecessary because it is infallible. Signed-off-by: Fredi Raspall <fredi@githedgehog.com>
Signed-off-by: Fredi Raspall <fredi@githedgehog.com>
Signed-off-by: Fredi Raspall <fredi@githedgehog.com>
This patch: - renames some result codes to better indicate their nature. - remaps some of the results to better-suited variants. - the goal is to make it easier to know what type or category of error to use in each case and unify the stringification. Signed-off-by: Fredi Raspall <fredi@githedgehog.com>
Signed-off-by: Fredi Raspall <fredi@githedgehog.com>
...dataplane use the same validation logic. This patch will be ferther simplified later. Signed-off-by: Fredi Raspall <fredi@githedgehog.com>
Before, we were storing the gateway name in a GwConfig object, which wrapped an ExternalConfig. This patch moves the gateway name to the ExternalConfig object itself, as this is more natural, simplifies the code and will allow for further simplifications. Signed-off-by: Fredi Raspall <fredi@githedgehog.com>
Since we store the gateway name and genid in the ExternalConfig, we don't need to call validate_metadata() since that is called already in the TryFrom implementation to decode the spec into an ExternalConfig object. This further ensures that both dataplane and the validator attempt to process a spec using exactly the same logic. Signed-off-by: Fredi Raspall <fredi@githedgehog.com>
Fredi-raspall
force-pushed
the
pr/fredi/cleanup-and-validation
branch
from
15bb24c to
5c4ea1f
Compare
Merged
Fredi-raspall
requested review from
sergeymatov
and removed request for
a team
qmonnet
reviewed
Jan 30, 2026
Simplify the implementation of Ord for GwGroupMember, given that no two group members can have the same name. Signed-off-by: Fredi Raspall <fredi@githedgehog.com>
Fredi-raspall
force-pushed
the
pr/fredi/cleanup-and-validation
branch
from
5c4ea1f to
8196637
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work is not finished but can be safely merged, since I'll be working on other higher prio matters and don't want it to rod.