Pr/fredi/nat use cases #1257
Draft
Pr/fredi/nat use cases #1257
+131
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differentiate between 2 cases when logging: - no flow entry is found in table for a given key - did not build a flow key (because of the type of packet) Signed-off-by: Fredi Raspall <fredi@githedgehog.com>
Add srcVpcd to FlowTuple so that it gets displayed/logged too. The flowTuple type could be used as the single input to the lookup function. Signed-off-by: Fredi Raspall <fredi@githedgehog.com>
Make it such that no string needs to be created. Signed-off-by: Fredi Raspall <fredi@githedgehog.com>
Flow-filter should be the first stage so that other stages can use the flow-info. Up until now, the flow-filter couldn't because it preceeded the flow-lookup stage. Signed-off-by: Fredi Raspall <fredi@githedgehog.com>
Augment FlowInfoLocked to include a VpcDiscriminant so that we can determine the dst VPC from a flow entry as a fallback. Signed-off-by: Fredi Raspall <fredi@githedgehog.com>
Rename the type (NF) so that it is clear its purpose. Signed-off-by: Fredi Raspall <fredi@githedgehog.com>
Signed-off-by: Fredi Raspall <fredi@githedgehog.com>
Signed-off-by: Fredi Raspall <fredi@githedgehog.com>
If, in the flow filter, the destination vpc (discriminant) cannot be determined for a packet, try to discover it from the flow-info attached to the packet. Ofc, the correctness of this depends on whether we store a flow-entry for the corresponding flow and what information we keep there. Signed-off-by: Fredi Raspall <fredi@githedgehog.com>
Quentin Signed-off-by: Fredi Raspall <fredi@githedgehog.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.