Non-ASCII character logs and file names are garbled in the history view and changes view.

[shiena]

history from https://github.com/unity3d-jp/piranhan

The reason is that Process::OutputDataReceived character-encodes with Encoding.Default, so the encoding output from the command does not match the encoding.

That is here.
https://github.com/Unity-Technologies/mono/blob/a449454f2128b2c0bb62d5ce3b8e22ab6b71db39/mcs/class/System/System.Diagnostics/Process.cs#L1424

call hierarchy

BeginOutputReadLine
-> ProcessAsyncReader
-> ProcessAsyncReader::AddInput
-> Encoding::Default::GetString

Since Process::StandardOutput::ReadLine uses Process::StartInfo::StandardOutputEncoding, combining git -c i18n.logoutputencoding=utf8 log and Encoding.UTF8 will not garbled. However, since this is a synchronization process, Unity freezes until the command is finished.

Also, I have submitted a pull request on Unity's problem.
Unity-Technologies/mono#582

For Encoding.Default,

• Japanese Windows codepage is 932
• OSX is the same as Encoding.ASCII

[StanleyGoldman]

Thanks @shiena for such a thorough bug report

[StanleyGoldman]

I suspect this is the cause for #35

[shiena]

I compared Unity 2017's Scripting Runtime Version .NET 3.5 with .NET 4.6.
.NET 3.5 is the same result as previous Unity, but .NET 4.6 is perfect!

https://gist.github.com/shiena/0dcd5e44197fcd4dc03efe67d6622ffc