Fixes to populate remote url text field after publish

[StanleyGoldman]

Fixes #185

The problem here was due to the use of activeRemote in SettingsView.

When a user is publishing, they are looking at the HistoryView. Which means the SettingsView is disabled, and when a remote is added the event handler SettingsView.OnRepositoryChanged will not run and won't update activeRemote with the new value.

I removed activeRemote and switched it to Repository.CurrentRemote.

I also fixed two errors in the SettingsView that would appear in the user log.

[shana]

hmmm why is GitClient null here? is the view racing the EntryPoint initialize code?
Also, spaaaaaaaaace.

[shana]

This if should be with the condition above:

if ((cachedUser == null || String.IsNullOrEmpty(cachedUser.Name)) && GitClient != null)

[StanleyGoldman]

GitClient was null for me when I rebuilt code with Unity running. I then figured it was possible during a domain reload.

[StanleyGoldman]

I don't know which space we are referring to. 🙈

[shana]

This isn't being called anywhere, let's nuke it

[StanleyGoldman]

newRepositoryRemoteUrl and repositoryRemoteUrl are both used..

Unity/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/SettingsView.cs

Lines 344 to 345 in 4a208bd

	newRepositoryRemoteUrl = EditorGUILayout.TextField(GitRepositoryRemoteLabel + ": " + repositoryRemoteName, newRepositoryRemoteUrl);
	var needsSaving = newRepositoryRemoteUrl != repositoryRemoteUrl && !String.IsNullOrEmpty(newRepositoryRemoteUrl);

[shana]

This if should be with the condition above:

if ((cachedUser == null || String.IsNullOrEmpty(cachedUser.Name)) && GitClient != null)

[shana]

If I'm reading this correctly, none of these changes (except GitClient null check) are needed, and instead we should be setting remoteHasChanged = true in OnEnable so it refreshes the data on the next pass.

[StanleyGoldman]

Setting remoteHasChanged is not enough. We need to update activeRemote at some point.
Part of my thinking was that activeRemote was only read from here..

Unity/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/SettingsView.cs

Lines 229 to 239 in 30e665c

	hasRemote = activeRemote.HasValue && !String.IsNullOrEmpty(activeRemote.Value.Url);
	if (!hasRemote)
	{
	repositoryRemoteName = DefaultRepositoryRemoteName;
	newRepositoryRemoteUrl = repositoryRemoteUrl = string.Empty;
	}
	else
	{
	repositoryRemoteName = activeRemote.Value.Name;
	newRepositoryRemoteUrl = repositoryRemoteUrl = activeRemote.Value.Url;
	}

[shana]

Yeah, you're right, there's no point in having the field if it's only ever touched here, and it shouldn't be touched anywhere else anyway