This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Fix console message text to be in past tense #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanleyGoldman
changed the title
shana
reviewed
Aug 18, 2017
| Logging.Error(ex, "Error rotating log files"); | ||
| } | ||
|
|
||
| Debug.Log("Initializing GitHub for Unity log file: " + logPath); |
Member
There was a problem hiding this comment.
Oooh, this is an excellent chance to combine this message with the one above so we don't log into the console twice, there was someone complaining about that. How about
Debug.LogFormat("Initialized GitHub for Unity version {0}. Log file: {1}", ApplicationInfo.Version, logPath);?
shana
approved these changes
Aug 18, 2017
StanleyGoldman
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is normal for Unity3d to display the last Console Log message received in the status bar.
Some newer users are not always familiar with this and the user of active tense gives the impression that some ongoing process has yet to finish. link