Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Conversation

@StanleyGoldman
Copy link
Contributor

  • There is an enum called SubTab with members History, Changes, etc.
  • There are several sub classes of SubView: HistoryView, BranchesView, etc.

Window has a member HistoryTab et al. which is an instance of HistoryView et al.
It's rather confusing, I'm renaming them to be the same as the type, which isn't great but better than the -Tab suffix I felt.
The alternative would be to name them History et al.

@StanleyGoldman
Copy link
Contributor Author

#252 Depends on this

@StanleyGoldman
Copy link
Contributor Author

#261 Depends on this

shana
shana previously requested changes Sep 6, 2017
Copy link
Member

@shana shana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good apart from the Window.cs.orig file that was mistakenly pushed along with the rest of the stuff.

@StanleyGoldman
Copy link
Contributor Author

Rebased

@StanleyGoldman StanleyGoldman dismissed shana’s stale review September 6, 2017 18:14

Failure condtions have changed

@StanleyGoldman StanleyGoldman merged commit 3b8c39c into master Sep 6, 2017
@StanleyGoldman StanleyGoldman deleted the fixes/refactor-window branch September 6, 2017 18:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants